[libdvdcss-devel] libdvdcss 1.2.11 regression

[David Woodhouse]

As described by Dan Haim in
http://mailman.videolan.org/pipermail/libdvdcss-devel/2012-January/000613.html
libdvdcss 1.2.11 is failing on certain drives where 1.2.10 used to work correctly.

This patch seems to fix it; is there a reason not to apply it?

I'd like to get this fixed in the Fedora package but the packager is
understandably reticent about doing so without upstream approval of the
patch.

diff --git a/src/css.c b/src/css.c
index 4d86016..5cc4b34 100644
--- a/src/css.c
+++ b/src/css.c
@@ -138,8 +138,10 @@ int _dvdcss_test( dvdcss_t dvdcss )

if( i_ret < 0 )
{
- print_error( dvdcss, "css error: could not get RPC status" );
- return -2;
+ print_debug( dvdcss, "css error: could not get RPC status; assuming RPC-1 drive" );
+ i_rpc = 0;
+ i_type = 0;
+ i_mask = 0;
}

switch( i_rpc )

[Jean-Baptiste Kempf]

Post by David Woodhouse
diff --git a/src/css.c b/src/css.c

More or less applied.

Thanks

Best regards,

[Dan Haim]

Thank you for commiting this.

-----Original Message-----
From: libdvdcss-devel-***@videolan.org [mailto:libdvdcss-devel-***@videolan.org] On Behalf Of Jean-Baptiste Kempf
Sent: Saturday, February 18, 2012 6:23 PM
To: Mailing list for libdvdcss developers
Subject: Re: [libdvdcss-devel] libdvdcss 1.2.11 regression

Post by David Woodhouse
diff --git a/src/css.c b/src/css.c

More or less applied.

Thanks

Best regards,

--
Jean-Baptiste Kempf
http://www.jbkempf.com/ - [phone] Sent from my Electronic Device _______________________________________________
libdvdcss-devel mailing list
libdvdcss-***@videolan.org
http://mailman.videolan.org/listinfo/libdvdcss-devel

[Remi Collet]

Post by Jean-Baptiste Kempf

Post by David Woodhouse
diff --git a/src/css.c b/src/css.c

More or less applied.

Thanks for this.

The patch will be part of the next package for Fedora, RHEL, CentOS and
other clones.


Regards,
Remi.

[Jean-Baptiste Kempf]

Post by Remi Collet

Post by Jean-Baptiste Kempf

Post by David Woodhouse
diff --git a/src/css.c b/src/css.c

More or less applied.

Thanks for this.
The patch will be part of the next package for Fedora, RHEL, CentOS and
other clones.

I do not know yet when to do the next release.

[Remi Collet]

Post by Jean-Baptiste Kempf
I do not know yet when to do the next release.

The next package is 1.2.11-2, which is 1.2.11 + this patch ;)

[David Woodhouse]

Post by Jean-Baptiste Kempf

Post by David Woodhouse
diff --git a/src/css.c b/src/css.c

More or less applied.

Thanks. Note that the drive on which I had this problem is the UJ-898 in
a MacBook Pro — I suspect a lot of Matshita drives used in Apple
machines will have the same problem.

I presume the VLC 2.0 binaries which were just pushed out for MacOS
using libdvdcss 1.2.11 *don't* have this fix. So they're not going to
work.