CACHE (on disk) patch for libdvdcss 1.2.2

[Arpi]

Hi,

I've updated/merged our cache patch (from mplayer's libmpdvdkit) for
libdvdcss, as it's the only difference between our patched code and
the 'original' lib now. (other changes we did are already in your tree too)

So, if you're interested, apply this patch:

ftp://mplayerhq.hu/MPlayer/releases/libdvdcss-1.2.2.cache.diff

To enable, choose one of:
- set DVDCSS_CACHE to an existing path where you want the cache files/dirs
be created (one subdir per disc, containing one 5-byte file per key)
- set variable dvdcss_cache_dir (char*) from the caller application


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu

[Christophe Massiot]

Why hasn't this patch been merged in ?

Post by Arpi
I've updated/merged our cache patch (from mplayer's libmpdvdkit) for
libdvdcss, as it's the only difference between our patched code and
the 'original' lib now. (other changes we did are already in your tree too)
ftp://mplayerhq.hu/MPlayer/releases/libdvdcss-1.2.2.cache.diff
- set DVDCSS_CACHE to an existing path where you want the cache files/dirs
be created (one subdir per disc, containing one 5-byte file per key)
- set variable dvdcss_cache_dir (char*) from the caller application
A'rpi / Astral & ESP-team
--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu

[Samuel Hocevar]

Post by Christophe Massiot
Why hasn't this patch been merged in ?

Because I don't like the code as it is. Not only the coding style
(uses tabs, has braces at weird places), but it also outputs to stderr,
assumes we're using a disk while we could actually be reading a VOB,
assumes we can seek to a given location in the stream without checking
the return value, same for mkdir(), uses a lame malloc(16+4) for fixed
size volatile data that gets freed 3 lines below...

Well the feature is probably good, but the code needs rewriting and
I haven't even had time to test it.

[Samuel Hocevar]

Post by Arpi
ftp://mplayerhq.hu/MPlayer/releases/libdvdcss-1.2.2.cache.diff
- set DVDCSS_CACHE to an existing path where you want the cache files/dirs
be created (one subdir per disc, containing one 5-byte file per key)
- set variable dvdcss_cache_dir (char*) from the caller application

Hi, I found some time to review your patch and rewrite the parts that
didn't please me for various reasons. I did not use the dvdcss_cache_dir
variable because it breaks the API compatibility, it's not thread-safe,
and I don't think a new major number is justified yet. Client applications
can use setenv or putenv if they really need to change this value. A way
to address these issues will be provided in future versions.

Should the entire MPlayer team be credited for the code, or does the
copyright on the code belong to a specific individual?

Regards,