CVS Commit: libdvdcss (gbazin)

[c***@videolan.org]

Update of /var/cvs/videolan/libdvdcss
Modified Files:
ChangeLog

Log Message:

* ChangeLog: updated changelog.

[c***@videolan.org]

Update of /var/cvs/videolan/libdvdcss
Modified Files:
ChangeLog libdvdcss.spec

Update of /var/cvs/videolan/libdvdcss/debian
Modified Files:
changelog

Log Message:

* update changelogs.

[c***@videolan.org]

Update of /var/cvs/videolan/libdvdcss/src
Modified Files:
css.c ioctl.c

Log Message:

* src/css.c src/ioctl.c, src/libdvdcss.c: changed the work-around to detect
if the dvd is encrypted on Win2K in non-administrator mode.
Because we cannot use an ioctl to get the copyright status of the DVD,
we try to get the disc key and if this succeed, we assume the DVD is
encrypted, otherwise we assume it to be unencrypted.
I hope this logic is not too much flawed... at least it seems to be working
with the few DVDs I've got.

[H}kan Hjort]

Post by c***@videolan.org
Update of /var/cvs/videolan/libdvdcss/src
css.c ioctl.c
* src/css.c src/ioctl.c, src/libdvdcss.c: changed the work-around to detect
if the dvd is encrypted on Win2K in non-administrator mode.
Because we cannot use an ioctl to get the copyright status of the DVD,
we try to get the disc key and if this succeed, we assume the DVD is
encrypted, otherwise we assume it to be unencrypted.

It can also faild for a region missmatch.

Post by c***@videolan.org
I hope this logic is not too much flawed... at least it seems to be working
with the few DVDs I've got.

Sure if you either have a region free DVD drive or just DVD disc from
the same region as the drive.

[Gildas Bazin]

Post by H}kan Hjort

Post by c***@videolan.org
I hope this logic is not too much flawed... at least it seems to be working
with the few DVDs I've got.

Sure if you either have a region free DVD drive or just DVD disc from
the same region as the drive.

Would there be a better way to check for the copyright status of a DVD ?

The problem here only happens because we can't get the copyright status with
an IOCTL_DVD_READ_STRUCTURE and a DVD_COPYRIGHT_DESCRIPTOR query on
Win2k/XP (AFAIK it's a bug in these OSs).
We can work around this in administrator mode by sending a SCSI passthrough
command instead, but this isn't allowed in non-administrator mode.

--
Gildas

[Gildas Bazin]

Post by H}kan Hjort
Sure if you either have a region free DVD drive or just DVD disc from
the same region as the drive.

I just tried on a RPC-2 drive, set to region 2 and using a region 1 disc...
and this appears to be working fine.

--
Gildas

[H}kan Hjort]

Post by Gildas Bazin

Post by H}kan Hjort
Sure if you either have a region free DVD drive or just DVD disc from
the same region as the drive.

I just tried on a RPC-2 drive, set to region 2 and using a region 1 disc...
and this appears to be working fine.

Ah sorry my misstake.. I though of the title key. Though there are some
drives that act wierd reading the disc key on region missmatch.
(Not saying we should do anything about this though, there might even be
other drives that have problmes if the disc key is not read at all).

I have yet another patch in this area though.. i.e. if we discover an
encrypted block when reading and either don't have a key (it's all zero)
or the b_scrambled flag is false. What should we do?

I have a patch that for the last case sets the flag to true, and tries
to get the disc key followed by the title key at this possition.
Do you think it's any idea to do this?
(It's untested code I'm sorry to say, no DVD drive here)

What of the case when we fail to get the key, or when the key was zero?

[Gildas Bazin]

Post by H}kan Hjort
I have a patch that for the last case sets the flag to true, and tries
to get the disc key followed by the title key at this possition.
Do you think it's any idea to do this?
(It's untested code I'm sorry to say, no DVD drive here)

This patch would solve the particular problem I got because the
ioctl_ReadCopyright() call becomes much less important with this.

If nobody sees any objections, I will apply the patch once we have released
libdvdcss-1.2.4 so it can have some testing.

Post by H}kan Hjort
What of the case when we fail to get the key, or when the key was zero?

Don't really know :(

Thanks,

--
Gildas

[c***@videolan.org]

Update of /var/cvs/videolan/libdvdcss
Modified Files:
ChangeLog libdvdcss.spec

Update of /var/cvs/videolan/libdvdcss/debian
Modified Files:
changelog

Log Message:

* updated the changelogs for the 1.2.4 release.