[libdvdcss-devel] [PATCH] support ELF visibility attribute

[Fabian Greffrath]

Hi again,

after another 4 weeks, could someone please review my patch of July
11th, re-attached for your convenience?

Thanks,
Fabian

[Diego Biurrun]

Post by Fabian Greffrath
after another 4 weeks, could someone please review my patch of July
11th, re-attached for your convenience?
Here is the autotools patch I was talking about ...

It looks mostly OK. The only thing is that xine and netembryo (part of
LScube) already have a macro to check the flag and attribute so I would
suggest using that, but it should be okay either way.

--
Diego Elio Pettenò — Flameeyes
***@flameeyes.eu — http://blog.flameeyes.eu/

So if you're willing to go the extra mile that would be great, otherwise
j-b should just go ahead and apply your patch :)

Diego

[Fabian Greffrath]

Post by Diego Biurrun
It looks mostly OK. The only thing is that xine and netembryo (part of
LScube) already have a macro to check the flag and attribute so I would
suggest using that, but it should be okay either way.

But this would mean adding m4/attributes.m4 and stuff just for this
one check.

Post by Diego Biurrun
So if you're willing to go the extra mile that would be great, otherwise
j-b should just go ahead and apply your patch :)

I'd appreciate if we kept this specific check and the whole autoconf
for libdvdcss as simple as possible.

- Fabian

[Jean-Baptiste Kempf]

Post by Fabian Greffrath
I'd appreciate if we kept this specific check and the whole autoconf
for libdvdcss as simple as possible.

autoconf and simple?

:)

[Fabian Greffrath]

Post by Jean-Baptiste Kempf
autoconf and simple?

So, are you going to apply my patch?

- Fabian

[Jean-Baptiste Kempf]

Post by Fabian Greffrath

Post by Jean-Baptiste Kempf
autoconf and simple?

So, are you going to apply my patch?

Asked sooooo nicely...

Applied.

[Fabian Greffrath]

Post by Jean-Baptiste Kempf
Applied.

Yeeha, thank you very much! \o/