[libdvdcss-devel] "warnings cleanup" commit breaks functionality

[s***@goeswhere.com]

I cannot see why, but the commit:

c500fe5227012ac04ec0b91c6c29606bad246839:
device: Adjust types in offset calculations

... causes me to be unable to retrieve keys for some tracks on some
DVDs. Reverting the commit and reinstalling causes everything to work
as expected.

This commit is not in the stable release, i.e. the stable release works
fine.

This happens with track 2 onwards, but not track 1, with every disc in
this box set. 4 main tracks per disc (40 minute episodes). Legit DVDs,
believed circa 2008 although recently purchased.

Wild guess, without understanding the code at all: It is doing something
wrong somewhere else, which is not fatal, and this commit causes it to
report an error, which exists, but isn't fatal.

amd64 Ubuntu 14.10, 3.16.0-28-generic, gcc 4.9.1-16ubuntu6.

[ 1.575775] ata3.00: ATAPI: TSSTcorp CDDVDW SH-S202H, SB00, max UDMA/66
[ 1.591711] ata3.00: configured for UDMA/66
[ 1.593824] scsi 2:0:0:0: CD-ROM TSSTcorp CDDVDW SH-S202HSB00 PQ: 0 ANSI: 5
[ 1.609202] sr0: scsi3-mmc drive: 48x/48x writer dvd-ram cd/rwxa/form2 cdda tray
[ 1.609206] cdrom: Uniform CD-ROM driver Revision: 3.20
[ 1.609386] sr 2:0:0:0: Attached scsi CD-ROM sr0
[ 1.609500] sr 2:0:0:0: Attached scsi generic sg0 type 5


e.g.

% DVDCSS_VERBOSE=2 mplayer dvd://2
MPlayer2 2.0-728-g2c378c7-2ubuntu3 (C) 2000-2012 MPlayer Team

Playing dvd://2.
libdvdcss debug: opening target `/dev/dvd'
libdvdcss debug: using libc API for access
libdvdcss debug: disc reports copyright information 0x1
libdvdcss debug: drive region(s) 2, region mask 0xfd, RPC-II, region code set
libdvdcss debug: disc is scrambled
libdvdcss debug: requesting authentication grant ID (AGID)
libdvdcss debug: drive authenticated, using variant 0
libdvdcss debug: authentication established
libdvdcss debug: authentication success flag set, ASF=1
libdvdcss debug: decrypting disc key 3c:0e:34:a3:8e
libdvdcss debug: trying player key 01:af:e3:12:80
libdvdcss debug: decrypted disc key is 2e:97:32:1f:2a
libdvdcss debug: Content Scrambling System (CSS) key cache dir:
/home/faux/.dvdcss/NCIS_S4_EU_D5-2008032818285400-2e97321f2a/
There are 24 titles on this DVD.
There are 1 angles in this DVD title.

libdvdread: Attempting to retrieve all CSS keys
libdvdread: This can take a _long_ time, please be patient

libdvdread: Get key for /VIDEO_TS/VIDEO_TS.VOB at 0x0000015a
libdvdcss debug: title key found in cache c0:00:00:00:01
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_01_0.VOB at 0x0000026e
libdvdcss debug: title key found in cache c0:00:00:00:01
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_01_1.VOB at 0x00000798
libdvdcss debug: title key found in cache c0:00:00:00:01
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_02_0.VOB at 0x0031ab2f
libdvdcss debug: title key found in cache c0:00:00:00:02
libdvdcss error: seek error
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_02_0.VOB
(0x0031ab2f)
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_02_1.VOB at 0x0031abe2
libdvdcss debug: title key found in cache c0:00:00:00:02
libdvdcss error: seek error
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_02_1.VOB
(0x0031abe2)!!
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_03_0.VOB at 0x0031c5b1
libdvdcss debug: title key found in cache c0:00:00:00:03
libdvdcss error: seek error
libdvdread: Error cracking CSS key for /VIDEO_TS/VTS_03_0.VOB
(0x0031c5b1)
libdvdread: Elapsed time 0
libdvdread: Get key for /VIDEO_TS/VTS_03_1.VOB at 0x0031c664
libdvdcss debug: title key found in cache c0:00:00:00:03
libdvdcss error: seek error

etc.

[Jean-Baptiste Kempf]

Post by s***@goeswhere.com
... causes me to be unable to retrieve keys for some tracks on some
DVDs. Reverting the commit and reinstalling causes everything to work
as expected.

Reverting on top of HEAD?

Did you try to revert only part of the commit?

With my kindest regards,

[Jean-Baptiste Kempf]

Post by Jean-Baptiste Kempf

Post by s***@goeswhere.com
... causes me to be unable to retrieve keys for some tracks on some
DVDs. Reverting the commit and reinstalling causes everything to work
as expected.

Reverting on top of HEAD?
Did you try to revert only part of the commit?

I mean, only the libc_read part.

With my kindest regards,

[Jean-Baptiste Kempf]

Post by s***@goeswhere.com
device: Adjust types in offset calculations

I cannot see why either, but reverted.

Can you test the latest git, please?

With my kindest regards,