[libdvdcss-devel] [PATCH] gracefully continue if GetBusKey fails

[Diego Biurrun]

Reimar just committed the attached patch with the following log message
to MPlayer:

------------------------------------------------------------------------
r31094 | reimar | 2010-04-25 18:39:39 +0200 (Sun, 25 Apr 2010) | 2 lines
Changed paths:
M /trunk/libdvdcss/css.c

Try other methods also if GetBusKey fails instead of failing completely.
------------------------------------------------------------------------

I think it's fit for upstream, so here it is, please apply.

Diego

[Diego Biurrun]

*ping*

Post by Diego Biurrun
Reimar just committed the attached patch with the following log message
------------------------------------------------------------------------
r31094 | reimar | 2010-04-25 18:39:39 +0200 (Sun, 25 Apr 2010) | 2 lines
M /trunk/libdvdcss/css.c
Try other methods also if GetBusKey fails instead of failing completely.
------------------------------------------------------------------------
I think it's fit for upstream, so here it is, please apply.
--- src/css.c (revision 230)
+++ src/css.c (working copy)
@@ -425,7 +425,7 @@
/* We need to authenticate again every time to get a new session key */
if( GetBusKey( dvdcss ) < 0 )
{
- return -1;
+ i_ret = -1;
}

Come on guys, this should be quick to review and apply..

Diego

[Arnt Gulbrandsen]

Post by Diego Biurrun
*ping*

I'm not sure how to get patches in or contact the developers, but this
list isn't it. Sending mail to the (two?) other addresses I found isn't
any better.

Maybe a vlc list? Please let me know if you manage to get the patch
accepted.

Arnt

[Diego Biurrun]

Post by Arnt Gulbrandsen

Post by Diego Biurrun
*ping*

I'm not sure how to get patches in or contact the developers, but this
list isn't it. Sending mail to the (two?) other addresses I found isn't
any better.
Maybe a vlc list? Please let me know if you manage to get the patch
accepted.

Pinging Jean-Baptiste Kempf on IRC helps. He is known as j-b on freenode.

Unfortunately the persons currently listed as maintainers on paper (Samuel
Hocevar), don't do any maintenance at all. From what j-b tells me Sam is
nevertheless unwilling to pass the baton along. It is a very unfortunate
situation.

I had entertained the notion of forking libdvdcss on the MPlayer project
server for a while, but I'd much rather see j-b take over...

Diego

[Jean-Baptiste Kempf]

Hello Diego,

Post by Diego Biurrun
Come on guys, this should be quick to review and apply..

This is applied as of rev 231 of the VCS

Thanks a lot for the patch

Best Regards,

[Diego Biurrun]

Post by Jean-Baptiste Kempf

Post by Diego Biurrun
Come on guys, this should be quick to review and apply..

This is applied as of rev 231 of the VCS

Thanks.

Do you plan to make a new release in the foreseeable future?

Diego

[Jean-Baptiste Kempf]

Hello,

Post by Diego Biurrun
Do you plan to make a new release in the foreseeable future?

I believe we could, but I believe I saw a lot of complaints during the
VLC 1.1.0 testing phase with a SVN version of libdvdcss instead of
1.2.10, especially regarding different cross-regions playback.

So, once this is fixed, I don't see why not.

Best Regards,

[Diego Biurrun]

Post by Jean-Baptiste Kempf

Post by Diego Biurrun
Do you plan to make a new release in the foreseeable future?

I believe we could, but I believe I saw a lot of complaints during the
VLC 1.1.0 testing phase with a SVN version of libdvdcss instead of
1.2.10, especially regarding different cross-regions playback.

Did you manage to locate the revision that broke it?

Diego

[Jean-Baptiste Kempf]

Post by Diego Biurrun
Did you manage to locate the revision that broke it?

No, I hadn't had the time to.

Best Regards,

PS: I believe I changed the Reply-To: , please complain if it doesn't
work for you.

[Diego Biurrun]

Post by Jean-Baptiste Kempf

Post by Diego Biurrun
Did you manage to locate the revision that broke it?

No, I hadn't had the time to.

If it helps, I can commit the svn revisions of libdvdcss to MPlayer one
by one in the hope that bug reports will get triggered...

Post by Jean-Baptiste Kempf
PS: I believe I changed the Reply-To: , please complain if it doesn't
work for you.

It's working fine.

[Diego Biurrun]

Post by Diego Biurrun

Post by Jean-Baptiste Kempf

Post by Diego Biurrun
Did you manage to locate the revision that broke it?

No, I hadn't had the time to.

If it helps, I can commit the svn revisions of libdvdcss to MPlayer one
by one in the hope that bug reports will get triggered...

I just synced MPlayer up to and including r225 + r229, r231 is already
present in MPlayer. Let's see if we receive any bug reports.

Diego

[Jean-Baptiste Kempf]

Post by Diego Biurrun
I just synced MPlayer up to and including r225 + r229, r231 is already
present in MPlayer. Let's see if we receive any bug reports.

Many thanks.

Best Regards,