[PATCH] device name parsing

[Joey Parrish]

Hello,

Here's a patch just committed to mpdvdkit2 in MPlayer CVS. This version
has been made against latest libdvdcss from viewcvs.

This patch changes device name parsing to accept both X: and X:\ as raw
device names. I needed this because windows explorer hands the default
DVD Player a drive name in X:\ form.

Hope you find it useful.

Thanks,
--Joey

[Joey Parrish]

Post by Joey Parrish
Here's a patch just committed to mpdvdkit2 in MPlayer CVS. This version
has been made against latest libdvdcss from viewcvs.
This patch changes device name parsing to accept both X: and X:\ as raw
device names. I needed this because windows explorer hands the default
DVD Player a drive name in X:\ form.
Hope you find it useful.

Hello?

Ping videolan! Is this list still in use?

--Joey

[Sam Hocevar]

Post by Joey Parrish
This patch changes device name parsing to accept both X: and X:\ as raw
device names. I needed this because windows explorer hands the default
DVD Player a drive name in X:\ form.

X:\ is a directory. Is there a reason for not fixing this at the
right place, ie. the libdvdread level?

Regards,

[Joey Parrish]

Post by Sam Hocevar

Post by Joey Parrish
This patch changes device name parsing to accept both X: and X:\ as raw
device names. I needed this because windows explorer hands the default
DVD Player a drive name in X:\ form.

X:\ is a directory. Is there a reason for not fixing this at the
right place, ie. the libdvdread level?

Yes, but I'd like it to be accepted as a device instead. Thus the
change. And I didn't change it at dvdread level because the dvdcss
level is where the device name parsing is done.

--Joey

[Gildas Bazin]

Post by Joey Parrish

Post by Sam Hocevar

Post by Joey Parrish
This patch changes device name parsing to accept both X: and X:\ as raw
device names. I needed this because windows explorer hands the default
DVD Player a drive name in X:\ form.

X:\ is a directory. Is there a reason for not fixing this at the
right place, ie. the libdvdread level?

Yes, but I'd like it to be accepted as a device instead. Thus the
change. And I didn't change it at dvdread level because the dvdcss
level is where the device name parsing is done.

Not that I mind the patch to be included in libdvdcss but if you are using
libdvdread, you'll have to do it in your plugin as well anyway because "X:
\" is a valid path as far as libdvdread is concerned.
libdvdread will try to open "X:" as a device but will open "X:\" as a DVD
dump (eg. you've copied the content of a DVD on the root directory of an
hard-drive), which is IMHO the expected way to do things.

--
Gildas

[Joey Parrish]

Post by Gildas Bazin

Post by Joey Parrish
Yes, but I'd like it to be accepted as a device instead. Thus the
change. And I didn't change it at dvdread level because the dvdcss
level is where the device name parsing is done.

Not that I mind the patch to be included in libdvdcss but if you are using
\" is a valid path as far as libdvdread is concerned.
libdvdread will try to open "X:" as a device but will open "X:\" as a DVD
dump (eg. you've copied the content of a DVD on the root directory of an
hard-drive), which is IMHO the expected way to do things.

Okay, nevermind then. This patch comes from MPlayer's mpdvdkit, which
is a combination of dvdread and dvdcss. It works there. If this
changes the expected behavior of your libraries, then it's not at all
neccessary. Just trying to be nice and send alterations upstream.

Sorry to waste your time,
--Joey

[Sam Hocevar]

Post by Joey Parrish
Okay, nevermind then. This patch comes from MPlayer's mpdvdkit, which
is a combination of dvdread and dvdcss. It works there.

How does it handle hard drive paths or directories mapped to drives?

Post by Joey Parrish
If this changes the expected behavior of your libraries, then it's not
at all neccessary.

Indeed. I suggest fixing this either at the highest level (ie, where
the application gets the drop), or in dvdread's dvd_reader.c.

Post by Joey Parrish
Just trying to be nice and send alterations upstream.

This is most appreciated.

Regards,

[Joey Parrish]

Post by Sam Hocevar

Post by Joey Parrish
Okay, nevermind then. This patch comes from MPlayer's mpdvdkit, which
is a combination of dvdread and dvdcss. It works there.

How does it handle hard drive paths or directories mapped to drives?

I honestly don't recall. I have never had unencrypted VOBs on a hard
drive to find out.

--Joey

[Gildas Bazin]

Post by Joey Parrish

Post by Sam Hocevar

Post by Joey Parrish
Okay, nevermind then. This patch comes from MPlayer's mpdvdkit, which
is a combination of dvdread and dvdcss. It works there.

How does it handle hard drive paths or directories mapped to drives?

I honestly don't recall. I have never had unencrypted VOBs on a hard
drive to find out.

You don't need unencrypted VOBs.
If the VOBS are encrypted, libdvdcss will be used to brute force crack the
encryption :)

--
Gildas