libdvdcss-1.2.6 .spec file is a mess

[Kipp Cannon]

Hi,

I'd like to give you guys a heads-up on the .spec file that gets
distributed with libdvdcss. Upto and including 1.2.5 it was in reasonably
good shape and I would often use it, unmodified, to build my .rpm's. In
1.2.6 the .spec file has taken a nose-dive. I'm working with RedHat 8.0.

I am led to believe that the included .spec file's intended platform is
Mandrake and that the problems I see are probably Mandrake <--> RH macro
differences. FWIW, I've included a cleaned-up .spec file below that works
on RedHat 8.0 w/ rpm-build 4.2. If you're interested, you can see what a
RedHat system needs and fix the compatibility macros in your .spec file.
Note that there is no need to define the %name, etc., macros and RedHat
has its own %configure and %makeinstall macros that work perfectly with
libdvdcss. Also note the omission of the changelog.

My criticisms aside, :-), thanks for the great work!

-Kipp


%define major 2
%define libname %{name}%{major}

Name: libdvdcss
Version: 1.2.6
Release: 1
Summary: Library for accessing DVDs like block devices with transparent decryption
Source: %{name}-%{version}.tar.bz2
License: GPL
Group: System/Libraries
URL: http://www.videolan.org/libdvdcss/
Packager: Yves Duret <***@zarb.org>
BuildRoot: %_tmppath/%name-%version-%release-root
Conflicts: libdvdcss0.0.1, libdvdcss0.0.2
%description
This description is not used.


%package -n %{libname}
Summary: Library for accessing DVDs like block devices with transparent decryption
Group: System/Libraries
Provides: %name = %version-%release
%description -n %{libname}
libdvdcss is a simple library designed for accessing DVDs like a block device
without having to bother about the decryption. The important features are:
* Portability: currently supported platforms are GNU/Linux, FreeBSD, NetBSD,
OpenBSD, BSD/OS, BeOS, Windows 95/98/ME, Windows NT/2000/XP, MacOS X,
Solaris, HP-UX and OS/2.
* Adaptability: unlike most similar projects, libdvdcss doesn't require the
region of your drive to be set and will try its best to read from the disc
even in the case of a region mismatch.
* Simplicity: a DVD player can be built around the libdvdcss API using no
more than 6 library calls.


%package -n %{libname}-devel
Summary: Development tools for programs which will use the %{name} library
Group: Development/C
Requires: %{libname} = %version-%release
Provides: %{name}-devel = %version-%release
%description -n %{libname}-devel
The %{name}-devel package includes the header files and static libraries
necessary for developing programs which will manipulate DVDs files using
the %{name} library.

If you are going to develop programs which will manipulate DVDs, you
should install %{name}-devel. You'll also need to have the %{name}
package installed.


%prep
%setup -q


%build
%configure
%__make


%install
%makeinstall


%clean
[ ${RPM_BUILD_ROOT} != "/" ] && rm -Rf ${RPM_BUILD_ROOT}
rm -Rf ${RPM_BUILD_DIR}/%{name}-%{version}


%post -n %{libname} -p /sbin/ldconfig


%postun -n %{libname} -p /sbin/ldconfig


%files -n %{libname}
%defattr(-,root,root)
%doc AUTHORS COPYING NEWS
%{_libdir}/*.so.*


%files -n %{libname}-devel
%defattr(-,root,root)
%doc ChangeLog COPYING
%{_libdir}/*.a
%{_libdir}/*.so
%{_libdir}/*.la
%{_includedir}/*

# changelog removed: strings like %pr*p etc. appear in it which confuses
# rpmbuild into thinking that these sections have been multiply-defined and
# it pukes.