Discussion:
Small regression in 1.2.5 on Solaris 8..
Vincent Cojot
2003-03-04 13:17:42 UTC
Permalink
Hi everyone (Bonjour a vous tous),

I'm following libdvdcss closely because I use oigle on Solaris 8/Sparc
to watch DVD's. A small change was introduced in libdvdcss-1.2.5 that
prevents it from compiling on Solaris 8 (Tested on SOlaris 8 02/02 Sparc).
Here is what happens:

gmake[3]: Entering directory `/usr/local/src/libdvdcss-1.2.5/src'
source='device.c' object='device.lo' libtool=yes \
depfile='.deps/device.Plo' tmpdepfile='.deps/device.TPlo' \
depmode=gcc /bin/bash ../depcomp \
/bin/bash ../libtool --mode=compile /opt/sfw/bin/gcc -DHAVE_CONFIG_H -I.
-I. -I.. -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -
DDVDCSS_DIST -Wsign-compare -Wall -pipe -O3 -c -o device.lo `test -f
'device.c' || echo './'`device.c
rm -f .libs/device.lo
/opt/sfw/bin/gcc -DHAVE_CONFIG_H -I. -I. -I.. -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -DDVDCSS_DIST -Wsign-compare -Wall -pipe
-O3 -c device.c -Wp,-MD,.deps/device.TPlo -fPIC -DPIC -o .libs/device.lo
In file included from device.c:59:
libdvdcss.h:51: `PATH_MAX' undeclared here (not in a function)
gmake[3]: *** [device.lo] Error 1
gmake[3]: Leaving directory `/usr/local/src/libdvdcss-1.2.5/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/local/src/libdvdcss-1.2.5/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/local/src/libdvdcss-1.2.5'
gmake: *** [all] Error 2

I'm not familiar with your coding style but here is a patch that fixes it
:

--- src/common.h.orig Wed Dec 11 10:06:07 2002
+++ src/common.h Tue Mar 4 13:54:43 2003
@@ -44,6 +44,10 @@
typedef signed int int32_t;
#endif

+#if defined(__sun__)
+# include<limits.h>
+#endif
+
#if defined( WIN32 )

/* several type definitions */


,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,
Vincent S. Cojot, Computer Engineering. STEP project. _.,-*~'`^`'~*-,._.,-*~
Ecole Polytechnique de Montreal, Comite Micro-Informatique. _.,-*~'`^`'~*-,.
Linux Xview/OpenLook resources page _.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'
http://step.polymtl.ca/~coyote _.,-*~'`^`'~*-,._ ***@step.polymtl.ca

They cannot scare me with their empty spaces
Between stars - on stars where no human race is
I have it in me so much nearer home
To scare myself with my own desert places. - Robert Frost
--
This is the libdvdcss-devel mailing-list, see http://developers.videolan.org/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <***@videolan.org>
Loading...