Thélesphonse Bigorneault
2011-02-18 01:45:18 UTC
I will not send further mails or patch, so please do not ask.
I discovered that there are some memory leaks with K1table variable in the
file src/css.c. For example, line 1156 there is no free() before return.
Also in ioctl.c line 877 the parameter 'pi_remove_me' is useless.
Please note that the C99 standard does not allow the macro to have a variable
number of arguments as for
#define print_debug (dvdcss, msg, args ...) in libdvdcss.h. It works with
gcc, but the behavior is "undefined" in the C99 standard (same thing for ISO
C++98), so it might not work properly with another compiler or even with future
versions of gcc.
Please include fixes for these in the next release.
TB
I discovered that there are some memory leaks with K1table variable in the
file src/css.c. For example, line 1156 there is no free() before return.
Also in ioctl.c line 877 the parameter 'pi_remove_me' is useless.
Please note that the C99 standard does not allow the macro to have a variable
number of arguments as for
#define print_debug (dvdcss, msg, args ...) in libdvdcss.h. It works with
gcc, but the behavior is "undefined" in the C99 standard (same thing for ISO
C++98), so it might not work properly with another compiler or even with future
versions of gcc.
Please include fixes for these in the next release.
TB